mirror of
https://github.com/felipegcoutinho/openmonetis.git
synced 2026-06-10 07:16:01 +00:00
refactor: faxina arquitetural — código morto, identificadores em inglês e estrutura padronizada
Refatoração estrutural sem mudanças funcionais. Saldo líquido: −428 linhas. Removido: - 14 funções/constantes mortas verificadas via grep no repo todo: validateCategoriaOwnership, getInstallmentAnticipationsAction, getAnticipationDetailsAction, formatDecimalForDb, currencyFormatterNoCents, optionalDecimalSchema, formatMonthLabel, getGoalProgressStatusColorClass, MONTH_PERIOD_PARAM, calculateRemainingInstallments, e 5 funções fetch* não usadas em inbox/queries.ts. - 1 tipo morto (ImportRow) + 2 órfãos consequentes (InstallmentAnticipationWithRelations, GoalProgressStatus convertido em interno). - ~30 export keywords desnecessários (símbolos usados apenas no próprio arquivo). - Re-exports mortos em barrels: EstablishmentLogoPicker, CategoryReportSkeleton, WidgetSkeleton, toNameKey. - Arquivo features/reports/types.ts (barrel inteiro era órfão). Padronizado (PT-BR→EN em identificadores expostos): - 4 constantes globais (LANCAMENTOS_* → TRANSACTIONS_*). - 12 tipos/interfaces (Lancamento*/Pagador*/Estabelecimento* → equivalentes EN). - 13 funções/components exportados (fetchPagador*, EstabelecimentoInput, PagadorInfoCard, etc.). - 5 props cross-file (preLancamentosCount → inboxPendingCount, pagadorAvatarUrl → payerAvatarUrl, etc.). - Mantidas em PT-BR conforme exceção do CLAUDE.md: variáveis locais (pagador, categoria, lancamento), accessor key pagadorName (persistida em preferências), strings de UI. Reorganizado: - transactions/: 14 helpers soltos na raiz movidos para lib/; barrel actions.ts reduzido de 76 linhas de wrappers para 14 linhas de re-exports puros; anticipation-actions.ts movido para actions/anticipation.ts. - dashboard/: 8 helpers soltos consolidados em dashboard/lib/. - reports/: 5 query files na raiz consolidados em reports/lib/. - payers/: detail-actions.ts (21KB) e detail-queries.ts movidos para payers/lib/. - shared/components/: 9 dos 16 componentes soltos agrupados em brand/, widgets/, feedback/. - shared/lib/fetch-json.ts movido para shared/utils/fetch-json.ts. Validação: pnpm exec tsc --noEmit (0 erros), biome check (0 issues), knip (sem unused). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
@@ -1,5 +1,5 @@
|
||||
import { LogoIcon } from "@/shared/components/logo-icon";
|
||||
import { LogoText } from "@/shared/components/logo-text";
|
||||
import { LogoIcon } from "@/shared/components/brand/logo-icon";
|
||||
import { LogoText } from "@/shared/components/brand/logo-text";
|
||||
import { cn } from "@/shared/utils/ui";
|
||||
|
||||
interface LogoProps {
|
||||
@@ -27,9 +27,9 @@ const sizeVariants = {
|
||||
},
|
||||
} as const;
|
||||
|
||||
export type CategoryIconBadgeSize = keyof typeof sizeVariants;
|
||||
type CategoryIconBadgeSize = keyof typeof sizeVariants;
|
||||
|
||||
export interface CategoryIconBadgeProps {
|
||||
interface CategoryIconBadgeProps {
|
||||
/** Nome do ícone Remix (ex: "RiShoppingBag3Line") */
|
||||
icon?: string | null;
|
||||
/** Nome da categoria — define cor e iniciais de fallback */
|
||||
|
||||
@@ -1,8 +1,3 @@
|
||||
export type {
|
||||
CategoryIconBadgeProps,
|
||||
CategoryIconBadgeSize,
|
||||
} from "./category-icon-badge";
|
||||
export { CategoryIconBadge } from "./category-icon-badge";
|
||||
export { EstablishmentLogo } from "./establishment-logo";
|
||||
export { EstablishmentLogoPicker } from "./establishment-logo-picker";
|
||||
export { LogoPrefetchProvider } from "./logo-prefetch-provider";
|
||||
|
||||
@@ -41,5 +41,3 @@ export function useMonthPeriod() {
|
||||
buildHref,
|
||||
};
|
||||
}
|
||||
|
||||
export { PERIOD_PARAM as MONTH_PERIOD_PARAM };
|
||||
|
||||
@@ -14,15 +14,15 @@ type AppNavbarProps = {
|
||||
email: string;
|
||||
image: string | null;
|
||||
};
|
||||
pagadorAvatarUrl: string | null;
|
||||
preLancamentosCount?: number;
|
||||
payerAvatarUrl: string | null;
|
||||
inboxPendingCount?: number;
|
||||
notificationsSnapshot: DashboardNotificationsSnapshot;
|
||||
};
|
||||
|
||||
export async function AppNavbar({
|
||||
user,
|
||||
pagadorAvatarUrl,
|
||||
preLancamentosCount = 0,
|
||||
payerAvatarUrl,
|
||||
inboxPendingCount = 0,
|
||||
notificationsSnapshot,
|
||||
}: AppNavbarProps) {
|
||||
const updateCheck = await checkForUpdate();
|
||||
@@ -36,14 +36,14 @@ export async function AppNavbar({
|
||||
unreadCount={notificationsSnapshot.unreadCount}
|
||||
visibleCount={notificationsSnapshot.visibleCount}
|
||||
budgetNotifications={notificationsSnapshot.budgetNotifications}
|
||||
preLancamentosCount={preLancamentosCount}
|
||||
inboxPendingCount={inboxPendingCount}
|
||||
/>
|
||||
<RefreshPageButton variant="navbar" />
|
||||
<AnimatedThemeToggler variant="navbar" />
|
||||
</div>
|
||||
<NavbarUser
|
||||
user={user}
|
||||
pagadorAvatarUrl={pagadorAvatarUrl}
|
||||
payerAvatarUrl={payerAvatarUrl}
|
||||
updateCheck={updateCheck}
|
||||
/>
|
||||
</NavbarShell>
|
||||
|
||||
@@ -26,7 +26,7 @@ export type NavItem = {
|
||||
hideOnMobile?: boolean;
|
||||
};
|
||||
|
||||
export type NavSection = {
|
||||
type NavSection = {
|
||||
label: string;
|
||||
items: NavItem[];
|
||||
};
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
import Link from "next/link";
|
||||
import { Logo } from "@/shared/components/logo";
|
||||
import { Logo } from "@/shared/components/brand/logo";
|
||||
|
||||
type NavbarShellProps = {
|
||||
logoHref?: string;
|
||||
|
||||
@@ -45,13 +45,13 @@ type NavbarUserProps = {
|
||||
email: string;
|
||||
image: string | null;
|
||||
};
|
||||
pagadorAvatarUrl: string | null;
|
||||
payerAvatarUrl: string | null;
|
||||
updateCheck: UpdateCheckResult;
|
||||
};
|
||||
|
||||
export function NavbarUser({
|
||||
user,
|
||||
pagadorAvatarUrl,
|
||||
payerAvatarUrl,
|
||||
updateCheck,
|
||||
}: NavbarUserProps) {
|
||||
const router = useRouter();
|
||||
@@ -65,8 +65,8 @@ export function NavbarUser({
|
||||
setTimeout(() => setCopied(false), 2000);
|
||||
}
|
||||
|
||||
const avatarSrc = pagadorAvatarUrl
|
||||
? getAvatarSrc(pagadorAvatarUrl)
|
||||
const avatarSrc = payerAvatarUrl
|
||||
? getAvatarSrc(payerAvatarUrl)
|
||||
: user.image || getAvatarSrc(null);
|
||||
const isDataUrl = avatarSrc.startsWith("data:");
|
||||
|
||||
|
||||
@@ -25,7 +25,7 @@ export function NotificationBell(props: NotificationBellProps) {
|
||||
hasArchivedItems,
|
||||
archivedDashboardCount,
|
||||
hasVisibleItems,
|
||||
displayedPreLancamentosCount,
|
||||
displayedInboxPendingCount,
|
||||
displayedBudgetNotifications,
|
||||
invoiceNotifications,
|
||||
boletoNotifications,
|
||||
@@ -62,7 +62,7 @@ export function NotificationBell(props: NotificationBellProps) {
|
||||
|
||||
{hasVisibleItems ? (
|
||||
<NotificationBellContent
|
||||
displayedPreLancamentosCount={displayedPreLancamentosCount}
|
||||
displayedInboxPendingCount={displayedInboxPendingCount}
|
||||
displayedBudgetNotifications={displayedBudgetNotifications}
|
||||
invoiceNotifications={invoiceNotifications}
|
||||
boletoNotifications={boletoNotifications}
|
||||
|
||||
@@ -14,7 +14,7 @@ import {
|
||||
RiTimeLine,
|
||||
} from "@remixicon/react";
|
||||
import Image from "next/image";
|
||||
import StatusDot from "@/shared/components/status-dot";
|
||||
import StatusDot from "@/shared/components/feedback/status-dot";
|
||||
import { buttonVariants } from "@/shared/components/ui/button";
|
||||
import {
|
||||
Tooltip,
|
||||
@@ -33,7 +33,7 @@ import type {
|
||||
} from "./types";
|
||||
|
||||
type NotificationBellContentProps = {
|
||||
displayedPreLancamentosCount: number;
|
||||
displayedInboxPendingCount: number;
|
||||
displayedBudgetNotifications: ResolvedBudgetNotification[];
|
||||
invoiceNotifications: ResolvedDashboardNotification[];
|
||||
boletoNotifications: ResolvedDashboardNotification[];
|
||||
@@ -361,7 +361,7 @@ function formatDueDateDetail(
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
export function NotificationBellContent({
|
||||
displayedPreLancamentosCount,
|
||||
displayedInboxPendingCount,
|
||||
displayedBudgetNotifications,
|
||||
invoiceNotifications,
|
||||
boletoNotifications,
|
||||
@@ -372,7 +372,7 @@ export function NotificationBellContent({
|
||||
}: NotificationBellContentProps) {
|
||||
return (
|
||||
<div className="max-h-[460px] overflow-y-auto p-2">
|
||||
{displayedPreLancamentosCount > 0 && (
|
||||
{displayedInboxPendingCount > 0 && (
|
||||
<div>
|
||||
<SectionLabel
|
||||
icon={<RiAtLine className="size-3" />}
|
||||
@@ -382,9 +382,9 @@ export function NotificationBellContent({
|
||||
icon={<RiAtLine className="size-5 text-primary" />}
|
||||
isOverdue={false}
|
||||
title={
|
||||
displayedPreLancamentosCount === 1
|
||||
displayedInboxPendingCount === 1
|
||||
? "1 pré-lançamento pendente"
|
||||
: `${displayedPreLancamentosCount} pré-lançamentos pendentes`
|
||||
: `${displayedInboxPendingCount} pré-lançamentos pendentes`
|
||||
}
|
||||
detail="Aguardando revisão"
|
||||
onNavigate={onInboxNavigate}
|
||||
|
||||
@@ -34,5 +34,5 @@ export type NotificationBellProps = {
|
||||
unreadCount: number;
|
||||
visibleCount: number;
|
||||
budgetNotifications: BudgetNotification[];
|
||||
preLancamentosCount?: number;
|
||||
inboxPendingCount?: number;
|
||||
};
|
||||
|
||||
@@ -33,7 +33,7 @@ type UseNotificationBellReturn = {
|
||||
hasArchivedItems: boolean;
|
||||
archivedDashboardCount: number;
|
||||
hasVisibleItems: boolean;
|
||||
displayedPreLancamentosCount: number;
|
||||
displayedInboxPendingCount: number;
|
||||
displayedBudgetNotifications: ResolvedBudgetNotification[];
|
||||
invoiceNotifications: ResolvedDashboardNotification[];
|
||||
boletoNotifications: ResolvedDashboardNotification[];
|
||||
@@ -82,7 +82,7 @@ export function useNotificationBell({
|
||||
unreadCount: initialUnreadCount,
|
||||
visibleCount: initialVisibleCount,
|
||||
budgetNotifications,
|
||||
preLancamentosCount = 0,
|
||||
inboxPendingCount = 0,
|
||||
}: NotificationBellProps): UseNotificationBellReturn {
|
||||
const [open, setOpen] = useState(false);
|
||||
const [viewMode, setViewMode] = useState<NotificationViewMode>("active");
|
||||
@@ -178,19 +178,19 @@ export function useNotificationBell({
|
||||
const displayedDashboardCount = showArchived
|
||||
? displayedDashboardCountFromItems
|
||||
: activeDashboardCount;
|
||||
const displayedPreLancamentosCount = showArchived ? 0 : preLancamentosCount;
|
||||
const effectiveUnreadCount = unreadDashboardCountValue + preLancamentosCount;
|
||||
const displayedInboxPendingCount = showArchived ? 0 : inboxPendingCount;
|
||||
const effectiveUnreadCount = unreadDashboardCountValue + inboxPendingCount;
|
||||
const displayCount =
|
||||
effectiveUnreadCount > 99 ? "99+" : effectiveUnreadCount.toString();
|
||||
const hasUnreadNotifications = effectiveUnreadCount > 0;
|
||||
const hasVisibleItems =
|
||||
displayedDashboardCount + displayedPreLancamentosCount > 0;
|
||||
displayedDashboardCount + displayedInboxPendingCount > 0;
|
||||
const hasArchivedItems = archivedDashboardCount > 0;
|
||||
const hasDashboardNotificationItems = dashboardNotificationCount > 0;
|
||||
const hasAnySourceItems =
|
||||
allResolvedNotifications.length +
|
||||
allResolvedBudgetNotifications.length +
|
||||
preLancamentosCount >
|
||||
inboxPendingCount >
|
||||
0;
|
||||
const headerCountLabel = `${effectiveUnreadCount} ${effectiveUnreadCount === 1 ? "pendente" : "pendentes"}`;
|
||||
|
||||
@@ -306,7 +306,7 @@ export function useNotificationBell({
|
||||
hasArchivedItems,
|
||||
archivedDashboardCount,
|
||||
hasVisibleItems,
|
||||
displayedPreLancamentosCount,
|
||||
displayedInboxPendingCount,
|
||||
displayedBudgetNotifications,
|
||||
invoiceNotifications,
|
||||
boletoNotifications,
|
||||
|
||||
@@ -3,10 +3,8 @@
|
||||
* Facilita a importação em outros componentes
|
||||
*/
|
||||
export { AccountStatementCardSkeleton } from "./account-statement-card-skeleton";
|
||||
export { CategoryReportSkeleton } from "./category-report-skeleton";
|
||||
export { DashboardGridSkeleton } from "./dashboard-grid-skeleton";
|
||||
export { DashboardMetricsCardsSkeleton } from "./dashboard-metrics-cards-skeleton";
|
||||
export { FilterSkeleton } from "./filter-skeleton";
|
||||
export { InvoiceSummaryCardSkeleton } from "./invoice-summary-card-skeleton";
|
||||
export { TransactionsTableSkeleton } from "./transactions-table-skeleton";
|
||||
export { WidgetSkeleton } from "./widget-skeleton";
|
||||
|
||||
@@ -9,8 +9,8 @@ import {
|
||||
DialogHeader,
|
||||
DialogTitle,
|
||||
} from "@/shared/components/ui/dialog";
|
||||
import type { WidgetCardProps } from "@/shared/components/widget-card";
|
||||
import WidgetCard from "@/shared/components/widget-card";
|
||||
import type { WidgetCardProps } from "@/shared/components/widgets/widget-card";
|
||||
import WidgetCard from "@/shared/components/widgets/widget-card";
|
||||
|
||||
const OVERFLOW_THRESHOLD_PX = 16;
|
||||
const EXPANDABLE_CONTENT_CLASSNAME =
|
||||
Reference in New Issue
Block a user