git.gladyson/openmonetis
1
0
Fork 1
mirror of https://github.com/felipegcoutinho/openmonetis.git synced 2026-05-09 11:01:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(attachments): limpar arquivos órfãos no S3 em deleções e reset

Browse Source 
Três caminhos de deleção não chamavam o cleanup de storage, deixando
arquivos órfãos no S3:

- deleteTransactionBulkAction: deleções por escopo de série (período,
  futuras, todas) agora coletam attachments vinculados antes do delete
  e disparam cleanupAttachmentsAfterTransactionDelete
- deleteMultipleTransactionsAction: mesma correção para seleção
  múltipla de lançamentos
- resetUserAppData: reset de conta em Ajustes coleta os fileKeys
  antes de truncar e remove os objetos do S3 em paralelo

Também ajusta deleteS3Object para ignorar NoSuchKey silenciosamente,
necessário para providers S3-compatíveis como Cloudflare R2 que não
são idempotentes nessa operação.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Felipe Coutinho
2026-04-25 14:45:45 +00:00
parent b14f487824
commit 7f05d2a681
3 changed files with 91 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

119
src/features/transactions/actions/bulk-actions.ts
View File

@@ -1,7 +1,7 @@
"use server";
import { and, asc, eq, inArray, isNull, sql } from "drizzle-orm";
import { transactions } from "@/db/schema";
import { attachments, transactionAttachments, transactions } from "@/db/schema";
import {
PAYMENT_METHODS,
TRANSACTION_CONDITIONS,
@@ -17,6 +17,7 @@ import {
import type { ActionResult } from "@/shared/lib/types/actions";
import { addMonthsToDate, parseLocalDateString } from "@/shared/utils/date";
import { addMonthsToPeriod, parsePeriod } from "@/shared/utils/period";
import { cleanupAttachmentsAfterTransactionDelete } from "./attachments";
import {
centsToDecimalString,
type DeleteBulkInput,
@@ -78,71 +79,64 @@ export async function deleteTransactionBulkAction(
};
}
let scopeFilter: ReturnType<typeof and>;
let successMessage: string;
if (data.scope === "current") {
await db
.delete(transactions)
.where(
and(eq(transactions.id, data.id), eq(transactions.userId, user.id)),
);
revalidate(user.id);
return { success: true, message: "Lançamento removido com sucesso." };
scopeFilter = eq(transactions.id, data.id);
successMessage = "Lançamento removido com sucesso.";
} else if (data.scope === "period") {
scopeFilter = and(
eq(transactions.seriesId, existing.seriesId),
eq(transactions.period, existing.period ?? ""),
);
successMessage = "Todos os lançamentos do período foram removidos.";
} else if (data.scope === "future") {
scopeFilter = and(
eq(transactions.seriesId, existing.seriesId),
sql`${transactions.period} >= ${existing.period}`,
);
successMessage = "Lançamentos removidos com sucesso.";
} else if (data.scope === "all") {
scopeFilter = eq(transactions.seriesId, existing.seriesId);
successMessage = "Todos os lançamentos da série foram removidos.";
} else {
return { success: false, error: "Escopo de ação inválido." };
}
if (data.scope === "period") {
await db
.delete(transactions)
.where(
and(
eq(transactions.seriesId, existing.seriesId),
eq(transactions.userId, user.id),
eq(transactions.period, existing.period ?? ""),
),
);
const targetRows = await db
.select({ id: transactions.id })
.from(transactions)
.where(and(scopeFilter, eq(transactions.userId, user.id)));
revalidate(user.id);
return {
success: true,
message: "Todos os lançamentos do período foram removidos.",
};
const targetIds = targetRows.map((r) => r.id);
if (targetIds.length === 0) {
return { success: false, error: "Nenhum lançamento encontrado." };
}
if (data.scope === "future") {
await db
.delete(transactions)
.where(
and(
eq(transactions.seriesId, existing.seriesId),
eq(transactions.userId, user.id),
sql`${transactions.period} >= ${existing.period}`,
),
);
const linkedAttachments = await db
.select({ id: attachments.id, fileKey: attachments.fileKey })
.from(transactionAttachments)
.innerJoin(
attachments,
eq(transactionAttachments.attachmentId, attachments.id),
)
.where(inArray(transactionAttachments.transactionId, targetIds));
revalidate(user.id);
return {
success: true,
message: "Lançamentos removidos com sucesso.",
};
}
await db
.delete(transactions)
.where(
and(
inArray(transactions.id, targetIds),
eq(transactions.userId, user.id),
),
);
if (data.scope === "all") {
await db
.delete(transactions)
.where(
and(
eq(transactions.seriesId, existing.seriesId),
eq(transactions.userId, user.id),
),
);
await cleanupAttachmentsAfterTransactionDelete(linkedAttachments);
revalidate(user.id);
return {
success: true,
message: "Todos os lançamentos da série foram removidos.",
};
}
return { success: false, error: "Escopo de ação inválido." };
revalidate(user.id);
return { success: true, message: successMessage };
} catch (error) {
return handleActionError(error);
}
@@ -759,6 +753,15 @@ export async function deleteMultipleTransactionsAction(
return { success: false, error: "Nenhum lançamento encontrado." };
}
const linkedAttachments = await db
.select({ id: attachments.id, fileKey: attachments.fileKey })
.from(transactionAttachments)
.innerJoin(
attachments,
eq(transactionAttachments.attachmentId, attachments.id),
)
.where(inArray(transactionAttachments.transactionId, data.ids));
await db
.delete(transactions)
.where(
@@ -768,6 +771,8 @@ export async function deleteMultipleTransactionsAction(
),
);
await cleanupAttachmentsAfterTransactionDelete(linkedAttachments);
const notificationData = existing
.filter(
(